{Compute Diagnostic} Update required args for spot-placement-recommender cli #30338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
zhoxing-ms
reviewed
Nov 14, 2024
| ) | ||
| _args_schema.desired_count = AAZIntArg( | ||
| options=["--desired-count"], | ||
| arg_group="SpotPlacementScoresInput", | ||
| help="Desired instance count per region/zone based on the scope.", | ||
| required=True, |
There was a problem hiding this comment.
Please note that required=True will cause breaking changes to the customer's automated scripts.
Due to the late submission of this PR, you have missed the train of breaking change window for this sprint. I suggest releasing the breaking change part in the next breaking change window (next year's build event sprint)
There was a problem hiding this comment.
Is there any choice to release it earlier before breaking change release? It is to correct the optional/required parameter. Today, if customers miss those parameter, they will get error from our api. I don't think this change will break the customer's script.
There was a problem hiding this comment.
Okay, got it. It's not considered a breaking change.
There was a problem hiding this comment.
@ joal42 It will be released in the next sprint (12-10)
zhoxing-ms
reviewed
Nov 14, 2024
| @@ -56,21 +59,28 @@ def _build_arguments_schema(cls, *args, **kwargs): | |||
| options=["--availability-zones"], | |||
| arg_group="SpotPlacementScoresInput", | |||
| help="Defines if the scope is zonal or regional.", | |||
| is_preview=True, | |||
There was a problem hiding this comment.
Additionally, labeling GA commands as is_preview is a recommended behavior. Is this because the previous PR forgot to mark it as preview?
There was a problem hiding this comment.
Right. the cli is in public preview stage. So, marking the parameters to public preview too.
zhoxing-ms
changed the title
zhoxing-ms
changed the title
zhoxing-ms
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az compute-recommender spot-placement-recommenderDescription
Update the required/ optional arguments for the
az compute-recommender spot-placement-recommendercommand.Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.